Fix warning for pattern match#179
Closed
Conversation
ghost
commented
Jul 16, 2015
- Easier testing for outsiders....
Collaborator
|
@dg-ratiodata I figured it out, why |
Collaborator
|
@dg-ratiodata try to rebase, should work now |
Author
|
Re-push to trigger rebuild |
Author
|
Finished. All green. |
Collaborator
|
I have a feeling, that re-pushing is not enough. You need to rebase against upstream master. This might help: https://gist.github.com/waterlink/ee7600e499d2ca8c596f |
Collaborator
|
Hmm, I don't quite understand how you did it green.. |
Author
|
Magic... No, just |
Collaborator
|
I see. Our travis setup uses pr/XXX/merge instead of pr/XXX/head. And I think it should use both. |
Collaborator
|
Ok, I will rebase manually and merge it. I don't want to make merge diversions in the tree. |
Author
|
ok. Thanks. |
Collaborator
|
Merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.